Skip auto rename and filename validator if WCF disabled or version <=32#201
Merged
Skip auto rename and filename validator if WCF disabled or version <=32#201
Conversation
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
… wcf-enabled-capability
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Windows Compatible Filenames (WCF) capability support with version-aware enforcement. The changes add a new windowsCompatibleFilenamesEnabled flag to server capabilities and implement logic to conditionally enforce filename restrictions based on the server version and configuration.
- Added
shouldEnforceWindowsCompatibleFilenamescomputed property to determine when WCF restrictions apply - Modified
FileNameValidatorandFileAutoRenamerto respect WCF capabilities - Migrated test suite from XCTest to Swift Testing framework with comprehensive test coverage for the new WCF logic
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/NextcloudKitUnitTests/FileNameValidatorUnitTests.swift | Migrated from XCTest to Swift Testing and added comprehensive tests for WCF version-aware behavior |
| Tests/NextcloudKitUnitTests/FileAutoRenamerUnitTests.swift | Refactored tests to use helper method and added WCF enforcement tests |
| Tests/NextcloudKitUnitTests/CheckWCFRestrictionsTests.swift | New test suite specifically for validating WCF restriction logic across different server versions |
| Sources/NextcloudKit/Utils/FileNameValidator.swift | Added capabilities parameter and early return when WCF is disabled |
| Sources/NextcloudKit/Utils/FileAutoRenamer.swift | Added capabilities parameter and conditional enforcement logic |
| Sources/NextcloudKit/NextcloudKit+Capabilities.swift | Added WCF flag parsing and version-aware enforcement logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| @Test("Returns true for version 30 when WCF is ALWAYS enabled. Flag is ignored.") | ||
| func returnsTrueForVersion30() { | ||
| let capabilities = makeCapabilities(serverMajor: 30, wcfEnabled: false) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
marinofaggiana
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements nextcloud/server#51568